Latex drawer extended for drawing circuits with single classical bit conditioning #6248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
enavarro51
reviewed
Sep 7, 2021
qiskit/visualization/latex.py
Outdated
Comment on lines
597
to
609
| cond_is_bit = isinstance(op.condition[0], Clbit) | ||
| if cond_is_bit: | ||
| cond_reg = self.bit_locations[op.condition[0]]["register"] | ||
| else: | ||
| cond_reg = op.condition[0] | ||
| creg_size = self.cregs[cond_reg] | ||
| if cond_is_bit: | ||
| if_value = op.condition[1] | ||
| else: | ||
| if_value = format(op.condition[1], "b").zfill(creg_size) | ||
| if not cond_is_bit: | ||
| if not self.reverse_bits: | ||
| if_value = if_value[::-1] |
There was a problem hiding this comment.
cond_is_bit = isinstance(op.condition[0], Clbit)
creg_size = self.cregs[cond_reg]
if cond_is_bit:
cond_reg = self.bit_locations[op.condition[0]]["register"]
if_value = op.condition[1]
else:
cond_reg = op.condition[0]
if_value = format(op.condition[1], "b").zfill(creg_size)
if not self.reverse_bits:
if_value = if_value[::-1]
This might be a bit more compact.
1ucian0
reviewed
Sep 23, 2021
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Sep 27, 2021
Add the assertion that the generated file is equal to the reference, and correct the reference file, from its inclusion in Qiskit#6248. The extra spacing added in the identifiers is consistent with a similar fix made to `test_latex_cif_single_bit.tex` within that PR, and the inclusion of the additional `\mathrm` macros appears to be a deliberate choice for bundles specifically (in `qiskit/visualization/latex.py`, current lines 247--248).
mergify bot
added a commit
that referenced
this pull request
Sep 28, 2021
Add the assertion that the generated file is equal to the reference, and correct the reference file, from its inclusion in #6248. The extra spacing added in the identifiers is consistent with a similar fix made to `test_latex_cif_single_bit.tex` within that PR, and the inclusion of the additional `\mathrm` macros appears to be a deliberate choice for bundles specifically (in `qiskit/visualization/latex.py`, current lines 247--248). Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes part of #6475 . This PR extends the current latex drawer to draw circuits that contain gates or instructions that are conditioned on a single classical bit.
Details and comments
This PR is a follow up of #6018 . The current latex drawer raises error when trying to draw a circuit that contains single bit conditioned gates. This PR tries to fix this error. A test has also been added. Examples of latex drawing are as below.