Fix cif bit bundle test #7064
Merged
Fix cif bit bundle test #7064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the assertion that the generated file is equal to the reference, and correct the reference file, from its inclusion in Qiskit#6248. The extra spacing added in the identifiers is consistent with a similar fix made to `test_latex_cif_single_bit.tex` within that PR, and the inclusion of the additional `\mathrm` macros appears to be a deliberate choice for bundles specifically (in `qiskit/visualization/latex.py`, current lines 247--248).
mtreinish
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the assertion that the generated file is equal to the reference, and
correct the reference file, from its inclusion in #6248.
The extra spacing added in the identifiers is consistent with a similar
fix made to
test_latex_cif_single_bit.texwithin that PR, and theinclusion of the additional
\mathrmmacros appears to be a deliberatechoice for bundles specifically (in
qiskit/visualization/latex.py,current lines 247--248).
Details and comments
Fix #7063.