Fix account instance logic #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psschwei
reviewed
Aug 8, 2025
ElePT
reviewed
Aug 18, 2025
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
kt474
added a commit
that referenced
this pull request
Aug 18, 2025
* Fix least_busy edge cases * add release note * add test * update test * update test and reno * Update release-notes/unreleased/2359.bug.rst Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> * Update test/integration/test_backend.py Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com> --------- Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently on
0.41.0, if there is a default saved instance, retrieving a backend and then attempting to create a session/batch will result in a "No API client found" error. In #2296, we added "instance" as a parameter when creating a backend. This made it so when creating a session,_get_api_clientwould look in the saved api clients which would be empty, instead of using_active_api_client. This only worked before because we weren't passing an instance to_get_api_clientso the current active client was used.qiskit-ibm-runtime/qiskit_ibm_runtime/qiskit_runtime_service.py
Lines 179 to 187 in 80837df
This code here is the main culprit:
The first issue is that if an instance name is passed in at initialization, the name instead of the crn will be the object key in
self._api_clientswhich causes errors later because_get_api_clientwon't be able to find a client.This logic is also flawed when an instance (name or crn) is saved in a account -
_get_or_create_cloud_client()only adds the client toself._api_clientsif the instance does not match the current active client instance. Sinceself._active_api_clientis initialized a couple lines above (with the saved account instance),self._api_clientswill remain empty which then also results in the no API client error.I also realized that in the case where there are no instances and the service looks at all instances available,
least_busy()was only using the current active instance. Theinstanceparameter also would not have worked correctly.Details and comments
Fixes #2358