Handle new IQP inconsistencies/breaking changes #2296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
commented
Jun 26, 2025
kt474
commented
Jun 26, 2025
| @@ -1259,7 +1261,8 @@ def jobs( | |||
| if instance: | |||
| if self._channel in ["ibm_cloud", "ibm_quantum_platform"]: | |||
| raise IBMInputValueError( | |||
| "The 'instance' keyword is only supported for ``ibm_quantum`` runtime." | |||
| "The 'instance' keyword is only supported for ``ibm_quantum`` runtime. " | |||
| "This parameter will be removed in a future release." | |||
There was a problem hiding this comment.
Same with this case - passing in instance already raises an error for the new channels. Do we still have to formally deprecate and then remove? Or can we just add to the error message and tell users it's going to be removed.
Merged
|
I think this PR is in a good spot to merge. If we find more issues in the removal PR we can handle them separately. |
ElePT
reviewed
Jul 4, 2025
There was a problem hiding this comment.
Thanks Kevin! the PR GLTM, I am just missing the deprecation warning mentioned in #2289 (comment). Maybe I can quickly push it myself.
kt474
added a commit
that referenced
this pull request
Jul 6, 2025
* Add tags instance filtering (#2277) * wip add tags & resource group instance prefs * add resource_group preference * add reno * add test * remove resource group & raise error correctly * reno typo * update integration test * add unit test * update tests and release note * Fix small typos (#2299) * fix typo in base_runtime_job.py estimation infromation for this job. -> estimation information for this job. * fix typo in runtime_job_v2.py primitive exeuction. -> primitive execution. * fix typo in noise_learner.py layers that occurr more frequently. -> layers that occur more frequently. * fix typo (#2302) * Handle new IQP inconsistencies/breaking changes (#2296) * new IQP breaking changes * remove delete_job test * add release note * remove instance RuntimeOption * deprecate properly * typo * fix reno & runtimeoptions, add test * address comments * Add queue_usage deprecation --------- Co-authored-by: ElePT <epenatap@gmail.com> * black --------- Co-authored-by: Kevin Tian <kevin.tian@ibm.com> Co-authored-by: Inho Choi <79438062+q-inho@users.noreply.github.com> Co-authored-by: Jessie Yu <jessieyu@us.ibm.com> Co-authored-by: ElePT <epenatap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles some pre-requisites of the IQP removal that will take place with #2289:
instanceparameter in thejobs()method, so it should be deprecated.service.usage()method was only meant for IQP Classic. We should have it return the data from/instances/usagein the new API.job.instance()to return the cloud CRN.Deprecate(First check what it does, I'm not sure if this option does anything). We can actually leaveinstanceoption inRuntimeOptionsRuntimeOptionsalone in this PR and look to remove the whole class (CleanupRuntimeOptions#2300). This class is not publicly documented and users are not supposed to set them directly.Details and comments
Fixes #2295
Also related to #1829