-
Notifications
You must be signed in to change notification settings - Fork 185
Remove IQP Classic #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove IQP Classic #2289
Conversation
I think this PR is ready for an initial review. Just like the Qiskit 2.0 support PR/release we may have to remove some methods without deprecation since they are no longer supported on the server anyway. Update: on hold for at least another month |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this @kt474, removals are never easy, but it is going to be sooo nice to see the cleaner logic once the channel is gone. I went through the code changes without looking at the tests yet and left a few questions and comments. Overall, I think that the PR is in a good place, but we'll have to use this extra time we get before the merging date to test the service and make sure we are not leaving any loose ends. I will take a look at the tests in a follow-up.
I think this is in a mergable state, we can keep a close eye on any followup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think that the PR is in a mergeable state, and we can keep testing from main once it's merged. I just added a couple of suggestions to avoid writing a date until the date is clear. Apart from that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Things I noticed that are handled in a separate PR (#2295).
TODO before merging:
ibm_quantum
accounts saved doesn't break anythingDetails and comments
Fixes #2285