Skip to content

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 14, 2025

Summary

Things I noticed that are handled in a separate PR (#2295).

TODO before merging:

  • Make sure dates in docs are correct
  • Test account logic and make sure having ibm_quantum accounts saved doesn't break anything
  • Double check things that may need proper deprecation

Details and comments

Fixes #2285

@kt474 kt474 changed the title [WIP] Remove IQP Classic Remove IQP Classic Jun 26, 2025
@kt474 kt474 marked this pull request as ready for review June 26, 2025 14:40
@kt474 kt474 added the Changelog: Removal Include in the Removed section of the changelog label Jun 26, 2025
@kt474
Copy link
Member Author

kt474 commented Jun 26, 2025

I think this PR is ready for an initial review. Just like the Qiskit 2.0 support PR/release we may have to remove some methods without deprecation since they are no longer supported on the server anyway.

Update: on hold for at least another month

@kt474 kt474 added the on hold label Jul 1, 2025
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this @kt474, removals are never easy, but it is going to be sooo nice to see the cleaner logic once the channel is gone. I went through the code changes without looking at the tests yet and left a few questions and comments. Overall, I think that the PR is in a good place, but we'll have to use this extra time we get before the merging date to test the service and make sure we are not leaving any loose ends. I will take a look at the tests in a follow-up.

@kt474
Copy link
Member Author

kt474 commented Jul 9, 2025

I think this is in a mergable state, we can keep a close eye on any followup

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think that the PR is in a mergeable state, and we can keep testing from main once it's merged. I just added a couple of suggestions to avoid writing a date until the date is clear. Apart from that, LGTM.

@ElePT ElePT removed the on hold label Jul 14, 2025
Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT enabled auto-merge July 15, 2025 07:38
@kt474 kt474 disabled auto-merge July 15, 2025 17:41
@kt474 kt474 merged commit ef9b4aa into Qiskit:main Jul 15, 2025
20 checks passed
@kt474 kt474 deleted the remove-all-old-iqp branch July 15, 2025 17:43
@ElePT ElePT added this to the 0.41.0 milestone Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused IQP classic code
2 participants