resolveLookupPathPath(): Fix caching of negative lookups #12481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids spamming in case the missing search path entry does not exist (NixOS#12480).
Ericson2314
reviewed
Feb 17, 2025
| @@ -57,7 +57,7 @@ Strings EvalSettings::getDefaultNixPath() | |||
| { | |||
| Strings res; | |||
| auto add = [&](const Path & p, const std::string & s = std::string()) { | |||
| if (pathAccessible(p)) { | |||
| if (std::filesystem::exists(p)) { | |||
Ericson2314
approved these changes
Feb 17, 2025
Ericson2314
added a commit
that referenced
this pull request
Feb 17, 2025
…2481 resolveLookupPathPath(): Fix caching of negative lookups (backport #12481)
edolstra
added a commit
that referenced
this pull request
Feb 18, 2025
…2481 resolveLookupPathPath(): Fix caching of negative lookups (backport #12481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This avoids spamming "Nix search path entry does not exist" (#12480).
Also, we no longer add entries to the default search path if their symlink target doesn't exist.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.