Skip to content

resolveLookupPathPath(): Fix caching of negative lookups (backport #12481) #12487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

resolveLookupPathPath(): Fix caching of negative lookups (backport #12481) #12487

merged 2 commits into from
Feb 18, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 17, 2025

Motivation

This avoids spamming "Nix search path entry does not exist" (#12480).

Also, we no longer add entries to the default search path if their symlink target doesn't exist.

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is an automatic backport of pull request #12481 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from edolstra as a code owner February 17, 2025 17:08
@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) conflicts merge-queue labels Feb 17, 2025
@mergify Mergify

This comment was marked as resolved.

Sign in to view
@edolstra
resolveLookupPathPath(): Fix caching of negative lookups
b706642 
This avoids spamming in case the missing search path entry does not
exist (#12480).

(cherry picked from commit df08e1e)
@edolstra edolstra force-pushed the mergify/bp/2.24-maintenance/pr-12481 branch from d94c659 to b706642 Compare February 18, 2025 15:58
@edolstra edolstra enabled auto-merge February 18, 2025 15:58
@edolstra edolstra merged commit 71f9301 into 2.24-maintenance Feb 18, 2025
25 checks passed
@edolstra edolstra deleted the mergify/bp/2.24-maintenance/pr-12481 branch February 18, 2025 16:27
@philiptaron philiptaron mentioned this pull request Mar 27, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees
No one assigned
Labels
automatic backport This PR is a backport produced by automation (does not trigger backporting) conflicts merge-queue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edolstra