-
Notifications
You must be signed in to change notification settings - Fork 874
Closed
Description
Feature Implementation History
Since 3 weeks ago, a new feature has been added to the Kubernetes decorator that allows for specifying image pull secrets. Please refer to #2400 to see the corresponding pull request.
Statement of the Current Issue
As a result of introducing this feature, it is expected that the final Argo Workflow YAML template contains the imagePullSecrets key under the spec block. However, this is unfortunately not the case, and the ImagePullSecrets key is not injected in the template. Consider the following Python code snippet and the expected workflow template:
- Python Snippet
@kubernetes( image='docker.io/some-private-repo/hello-world', image_pull_secrets=['docker-registry-secret'] ) @step def some_step: ...
- Expected Argo Workflow YAML File
apiVersion: argoproj.io/v1alpha1 kind: WorkflowTemplate metadata: name: hello-world spec: entrypoint: hello-world imagePullSecrets: !!<This is not added>!! - name: docker-registry-secret templates: - name: HelloWorldFlow container: image: hello-world command: [echo] args: ["hello world"]
Thanks for your consideration in advance. Let me know if there's any further information required on your side.
Metadata
Metadata
Assignees
Labels
No labels