fix: kubernetes imagePullSecrets support for argo workflows #2494
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valayDave
pushed a commit
to valayDave/metaflow
that referenced
this pull request
Jul 21, 2025
fix: kubernetes imagePullSecrets support for argo workflows Argo workflows does not support applying imagePullSecrets on a per-template basis, only on a workflow template level. Changing the implementation to leverage podSpecPatch in order to apply the imagePullSecrets on a per task basis JobSets were not tested but should be unaffected due to them utilizing `create` within the spec and simply dumping native k8s job specs WILL BE Removed after releasing 2.16+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argo workflows does not support applying imagePullSecrets on a per-template basis, only on a workflow template level.
Changing the implementation to leverage podSpecPatch in order to apply the imagePullSecrets on a per task basis
JobSets were not tested but should be unaffected due to them utilizing
createwithin the spec and simply dumping native k8s job specscloses #2477