feat: kubernetes image pull secrets
#2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for specifying Kubernetes container image pull secrets in the `kubernetes` step decorator. As an example: ```python @kubernetes( image='docker.io/some-private-repo/image', image_pull_secrets=['regcred'] ) @step def some_step: ... ``` Example output from `kubectl describe pod <some-pod>` on the `metaflow-dev` stack where `metaflow` was installed via `pip install -e </path/to/repo/checkout>`: ```console Events: Type Reason Age From Message ---- ------ ---- ---- ------- Normal Scheduled 1m default-scheduler Successfully assigned default/t-f03abf3d-2rpgp-j72q8 to minikube Normal Pulling 1m kubelet Pulling image "docker.io/some-private-repo/image" Normal Pulled 1m kubelet Successfully pulled image "docker.io/some-private-repo/image" in 669ms (670ms including waiting) Normal Created 1m kubelet Created container some-step Normal Started 1m kubelet Started container some-step ``` Resolves Netflix#1261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for specifying Kubernetes container image pull secrets in the
kubernetesstep decorator.As an example:
Example output from
kubectl describe pod <some-pod>on themetaflow-devstack wheremetaflowwas installed viapip install -e </path/to/repo/checkout>:Resolves #1261