feat: Enable Context Parallelism and Sequence Packing for MCore and Dtensor #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sahil Jain <sahilj@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Signed-off-by: Sahil Jain <sahilj@nvidia.com>
82411dd to
be26337
Compare
terrykong
previously approved these changes
Jul 21, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
terrykong
previously approved these changes
Jul 22, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
…tensor (#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com>
|
looks like a test failure, will submit a fix |
Signed-off-by: Terry Kong <terryk@nvidia.com>
terrykong
previously approved these changes
Jul 22, 2025
Signed-off-by: Sahil Jain <sahilj@nvidia.com>
Signed-off-by: Jonas yang <joyang@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com>
terrykong
approved these changes
Jul 22, 2025
This was referenced Jul 23, 2025
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
This was referenced Jul 24, 2025
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 28, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
…tensor (#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…tensor (NVIDIA-NeMo#704) Signed-off-by: Sahil Jain <sahilj@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jonas yang <joyang@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Co-authored-by: Jonas Yang CN <joyang@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Co-authored-by: Ahmad Kiswani <kiswani.ahmad@gmail.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed from #651, which combines MCore CP with Sequence Packing from #300 and CP fixes for DTensor from #678