feat: Enable CP during get_logprobs for dtensor worker. #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96480bc to
03d8333
Compare
03d8333 to
6835949
Compare
Signed-off-by: Jonas yang <joyang@nvidia.com>
6835949 to
7187c2d
Compare
terrykong
reviewed
Jul 18, 2025
| @@ -132,7 +132,7 @@ def dtensor_from_parallel_logits_to_logprobs( | |||
| """Get log probabilities from TP+CP sharded vocab logits. | |||
|
|
|||
| Args: | |||
| vocab_parallel_logits (DTensor): Logits distributed across tensor parallel workers, | |||
| vocab_parallel_logits (orch.Tensor): Logits distributed across tensor parallel workers, | |||
There was a problem hiding this comment.
Suggested change
| vocab_parallel_logits (orch.Tensor): Logits distributed across tensor parallel workers, | |
| vocab_parallel_logits (torch.Tensor): Logits distributed across tensor parallel workers, |
SahilJain314
approved these changes
Jul 18, 2025
SahilJain314
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Jonas yang <joyang@nvidia.com>
SahilJain314
pushed a commit
that referenced
this pull request
Jul 21, 2025
Signed-off-by: Jonas yang <joyang@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Enable CP for dtensor during get_logprobs. Such we could align with mcore path.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information