-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: lower Go version requirement to 1.23.0 #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lower Go version requirement to 1.23.0 #3679
Conversation
This should prevent compatibility issues with tools that are on 1.23 but not on the latest patch release there.
The Dagger CLI seems to be using 1.23.6 still. I wasn't sure if the language requirement of 1.23.8 was intentional or if 1.23.0 would also suffice in your scenario 🙂 Context: https://github.com/grafana/tanka/actions/runs/14571021118/job/40868199561?pr=1429 / grafana/tanka#1429 |
I'm not really entirely sure I understand how this works. I thought that the minor version of the Go directive would not have caused an issue. |
@StevenACoffman This also surprised me but perhaps it somehow different when explicitly setting a toolchain. Unfortunately, I didn't have time to set up a complete test-suite around this 🙁 Thanks for merging this! Hopefully this will get us unstuck soonish 😄 |
Can you circle back if you get more information? I worry I am downgrading people to Go 1.23.0 from later minor versions. |
Absolutely! Just for the record, that's the setup that we have with Dagger right now:
My interpretation of the spec is that setting One thing that I've noticed which might explain the whole cascade-of-conflicts here: When I add v0.17.72 as a dependency in a go.mod file and run |
I really need a test case that detects Go version directive changes and enforces the security policy with an actionable resolution to prevent this from just happening again and again. Apparently this is what's necessary to fix the
So then a script that runs that and checks whether git is dirty or something and tells people to run that and commit the result. Also, probably good to add |
Go directive reference |
This should prevent compatibility issues with tools that are on 1.23 but not on the latest patch release there.