It looks like you need to do this:

go generate ./...

and then commit your changes

It looks like you need to do this:

go generate ./...

and then commit your changes

Thank you, @StevenACoffman!
Yes, this is my first time committing to this project.

Thanks! I appreciate you working on this. It looks like you are still missing adding the ctx context.Context, argument change in at least two other places:

• https://github.com/z9905080/gqlgen/blob/master/graphql/executor/testexecutor/testexecutor.go#L120
• https://github.com/z9905080/gqlgen/blob/master/graphql/executor/testexecutor/testexecutor.go#L173

I checked and found two additional places that need to be fixed:

• graphql/handler/testserver/testserver.go

coverage: 73.349%. remained the same
when pulling b1eda1f on z9905080:master
into 492bf92 on 99designs:master.

coverage: 73.349%. remained the same when pulling b1eda1f on z9905080:master into 492bf92 on 99designs:master.

Do I need to take additional steps to address the test coverage issues?

Perhaps I could add some inconsequential test cases, but I'm not sure if that's a good approach.
In general, we don't specifically pursue such test cases.

Thank you for your persistence in continuing to work on this!

I'm not overly concerned with the specific code coverage number, and don't want inconsequential test cases cluttering things.

However, your original issue did not describe the symptom that would have been seen without your fix, or how to reproduce the circumstances when it would occur.

Now, we do not have a test that prevents someone from accidentally re-introducing the same bug.

Before your change, when resolver did NOT retrieve the context correctly, what would the error have been?

Would there be any possible test case that could have simulated the old error before your change?

Could you think of a test case that would provide some regression safety here? I'm going to merge it as is, but if you think of a useful test case, I would still love another PR for it.

Otherwise, I'm looking forward to your next contribution!