Update array.hpp #3769
Merged
Update array.hpp #3769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:Calling back on an empty container causes undefined behavior. Solution:Check with the function empty()
|
Thanks for the PR - please add a commit with a relicense statement https://github.com/zeromq/libzmq/blob/master/RELICENSE/README.md |
Adds relicensing grant
OK. |
|
You are right that calling |
|
OK，Your suggestion is more in line with zmq design，thank for you
发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用
发件人: Simon Giesecke<mailto:notifications@github.com>
发送时间: 2020年1月6日 23:12
收件人: zeromq/libzmq<mailto:libzmq@noreply.github.com>
抄送: xqcool<mailto:xuquan316@live.com>; Author<mailto:author@noreply.github.com>
主题: Re: [zeromq/libzmq] Update array.hpp (#3769)
You are right that calling back on an empty container has undefined behaviour, but this is not a legal use of array::erase anyway. Rather than changing the condition, the if should be removed entirely, or changed into zmq_assert (!_items.empty()); or rather zmq_assert (items.size() > index_);
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#3769?email_source=notifications&email_token=AHVTZ2BADKJWNATMGFNCQLTQ4NC6TA5CNFSM4KBTAVQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFXC5I#issuecomment-571175285>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHVTZ2GHINRPM64QT6HZL4DQ4NC6TANCNFSM4KBTAVQQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:Calling back on an empty container causes undefined behavior.
Solution:Check with the function empty()