Skip to content

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Jul 14, 2025

Description

Allows the creation of flavored skeleton packages.

Related Issue

Fixes #3985

Checklist before merging

Signed-off-by: Allen Conlon <software@conlon.dev>
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 43aa981
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6888c4b41db3ae0007ae9da3
😎 Deploy Preview https://deploy-preview-3986--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@a1994sc
Copy link
Contributor Author

a1994sc commented Jul 14, 2025

Leaving in draft mode because idk if this would end up being dead code

@a1994sc a1994sc marked this pull request as ready for review July 14, 2025 16:04
@a1994sc a1994sc requested review from a team as code owners July 14, 2025 16:04
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/package.go 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/layout/assemble.go 40.18% <100.00%> (+0.09%) ⬆️
src/pkg/packager/publish.go 63.11% <100.00%> (+0.61%) ⬆️
src/cmd/package.go 38.74% <50.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Allen Conlon <software@conlon.dev>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Allen Conlon <software@conlon.dev>
@AustinAbro321
Copy link
Contributor

Approved after make docs and schema is run

@a1994sc
Copy link
Contributor Author

a1994sc commented Jul 24, 2025

oh, right because I did the github auto-magic commit it did not update the docs... I will get that up in the next little bit

Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc a1994sc force-pushed the feat/skeleton-flavor branch from 09db770 to 4ae6988 Compare July 24, 2025 15:10
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an intuitive extension of skeleton packages, nice work.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jul 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2025
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jul 30, 2025
Merged via the queue into zarf-dev:main with commit b0d564b Jul 30, 2025
39 checks passed
@a1994sc a1994sc deleted the feat/skeleton-flavor branch July 30, 2025 18:16
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
Signed-off-by: Allen Conlon <software@conlon.dev>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create flavors of skeleton packages
3 participants