fix: identify file type using filename instead of mholt/archives auto detection #3977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
brandtkeller
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Stepped through the code - switching from Identify() to the internal findArchiver() resolves the initially reported problem of compression being incorrectly identified as brotli.
The requirement for extractor on DecompressOpts is driven from the inability to determine the extractor of a oci blob sha - which for Zarf should be .tar .
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
… detection (#3977) Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mholt/archives auto detection has been unreliable. Changing the code to instead detect the format using the filename
Fixes #3917
Checklist before merging