Skip to content

chore: wrap mutex around appending to failed repository updates #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

chore: wrap mutex around appending to failed repository updates #3934

merged 1 commit into from
Jun 27, 2025

Conversation

joonas
Copy link
Contributor

@joonas joonas commented Jun 21, 2025

Description

Appending to repoFailList from multiple goroutines is not concurrency safe, so let's wrap a sync.Mutex around the append.

Related Issue

Fixes #

Relates to #

Checklist before merging

@joonas joonas requested review from a team as code owners June 21, 2025 19:59
@joonas
chore: wrap mutex around appending to failed repository updates
a57f9b6 
Signed-off-by: Joonas Bergius <joonas@bergi.us>
@joonas joonas force-pushed the chore/sync-helm-repo-update-errors branch from 37b99db to a57f9b6 Compare June 21, 2025 19:59
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 37b99db
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68570f0d0016c700089becf6

@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit a57f9b6
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68570f2d7ce45f00085555d0

@brandtkeller
Copy link
Member

I don't think this is an unreasonable change - upstream implemented similar improvements - going to tap @AustinAbro321 for zarf/helm context on this one as for what our sync plan is on these files from helm.

@AustinAbro321
Copy link
Contributor

Yeah, we got helm/helm#13617 merged into Helm which will allow us to replace the quasi fork we have in Zarf with a simple call to Helm's NewRootCommand. That PR isn't getting backported into Helm 3 so we'll have to wait for Helm 4 (early 2025). In the meantime this seems like a reasonable addition. Thanks @joonas

@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/helm/repo_update.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/helm/repo_update.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jun 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2025
@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jun 27, 2025
Merged via the queue into zarf-dev:main with commit bd1b2de Jun 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinAbro321 AustinAbro321 AustinAbro321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joonas @brandtkeller @AustinAbro321