Skip to content

Conversation

TerryHowe
Copy link
Contributor

What this PR does / why we need it:
Tests occasionally fail with data race on tests for this. Seems likely this might happen for the CLI as well.

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2025
@robertsirc robertsirc added the v4.x Issues and Pull Requests related to the major version v4 label Jun 5, 2025
Copy link
Member

@robertsirc robertsirc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the repo-update-cmd-mutex branch from 8a1532a to 93ec064 Compare June 6, 2025 12:48
@TerryHowe
Copy link
Contributor Author

New commit is just gpg signed

Copy link
Collaborator

@mattfarina mattfarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattfarina mattfarina merged commit 9199335 into helm:main Jun 6, 2025
5 checks passed
@TerryHowe TerryHowe deleted the repo-update-cmd-mutex branch September 7, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. v4.x Issues and Pull Requests related to the major version v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants