Skip to content

Conversation

brandtkeller
Copy link
Member

@brandtkeller brandtkeller commented Mar 10, 2025

Description

Zarf needs objective criteria for reviewing new or modified behavior when submitted from any entity.

This will better allow capability review without the potential for interpreting the decision as subjective.

Related Issue

Fixes #3552

Relates to #

Checklist before merging

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller self-assigned this Mar 10, 2025
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit e493004
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6883cc4979dadd0008dc8770
😎 Deploy Preview https://deploy-preview-3562--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments for thought

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller marked this pull request as ready for review July 25, 2025 18:30
@brandtkeller brandtkeller requested review from a team as code owners July 25, 2025 18:30
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document looks great, and I'm generally in agreement with the principals. "measured by" includes many metrics, both qualitative and quantitative. Is the plan to work towards measuring and reporting these metrics over time? Or is the intent to say that these are the concrete impacts that these goals should have on Zarf?

@brandtkeller brandtkeller requested a review from Racer159 July 25, 2025 19:37
@brandtkeller
Copy link
Member Author

Is the plan to work towards measuring and reporting these metrics over time? Or is the intent to say that these are the concrete impacts that these goals should have on Zarf?

I'd say it's a mix of both that we can refine and report on iteratively where valuable. Some are guardrails - IE "Adoption of signed releases and integrity verification methods" <- we already do this but we want to ensure we don't violate this explicitly. Others are continual signals that need feedback loops - "Ensuring compatibility with industry standards". Then we get to things we can measure -> binary/package size / time to first successful deployment/ etc.

Broad enough to help us find applicable paths for new suggestions or existing logic.

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brandtkeller brandtkeller added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit 4408658 Aug 8, 2025
28 checks passed
@brandtkeller brandtkeller deleted the 3552_zarf_principles branch August 8, 2025 16:29
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the core Zarf principles
4 participants