Skip to content

Conversation

brandtkeller
Copy link
Member

Description

Adds an entry to the private-registry secret that zarf manages to support the internal service dns entry. More context for intent in the issue.

Related Issue

Fixes #4091

Checklist before merging

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
@brandtkeller brandtkeller self-assigned this Aug 16, 2025
@brandtkeller brandtkeller requested review from a team as code owners August 16, 2025 04:46
Copy link

netlify bot commented Aug 16, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 579e757
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68a00d2752b3bb0008213f30

Copy link

codecov bot commented Aug 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pkg/cluster/secrets.go 63.39% <100.00%> (+1.71%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandtkeller brandtkeller added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit 5ccd8ea Aug 18, 2025
27 checks passed
@brandtkeller brandtkeller deleted the 4091_svc_secret branch August 18, 2025 17:01
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
…zarf-dev#4092)

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support internal registry entry for secret
2 participants