fix(sdk): auto uppercase variables #4090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <austinabro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
brandtkeller
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
lgtm. Simple and aligns with the described CLI implementation
Ansible-man
pushed a commit
to Ansible-man/zarf
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com> Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name in variables are always made uppercase when they are used. We automatically make set variables from the CLI uppercase, and we only allow uppercase variables in the schema but there's no mechanism to make sure SDK variables are uppercase. This changes the variables package so we simply always make the variable names uppercase
Related Issue
Fixes #4081
Checklist before merging