Skip to content

Conversation

AustinAbro321
Copy link
Contributor

Description

This allows users to use absolute paths in values file with zarf packages

Related Issue

Fixes #3867

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 requested review from a team as code owners August 14, 2025 12:23
Copy link

netlify bot commented Aug 14, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 21fbcf3
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/689dd5583c63bc0008b28f61

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/layout/assemble.go 50.00% 2 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/create.go 54.54% <100.00%> (ø)
src/pkg/packager/layout/assemble.go 46.61% <50.00%> (+0.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 2277605 Aug 14, 2025
27 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-valuesfilepath branch August 14, 2025 14:47
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarf dev find-images errors on absolute path for valuesFiles
2 participants