Skip to content

chore: remove injector from this repo, use injector from zarf-dev/zarf-injector #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 21, 2025
Merged

chore: remove injector from this repo, use injector from zarf-dev/zarf-injector #4070

merged 5 commits into from
Aug 21, 2025

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Aug 11, 2025 •
edited
Loading

Description

This changes Zarf to use the injector for the repo that now owns it https://github.com/zarf-dev/zarf-injector

Related Issue

Fixes #2024, #4045

Checklist before merging

@AustinAbro321
switch injector
6ae0935 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify Netlify
Copy link

netlify bot commented Aug 11, 2025 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 0789792
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68a3597aaf4d850008348b24

@AustinAbro321
reset to main
1f0b30a 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AustinAbro321 AustinAbro321 marked this pull request as ready for review August 12, 2025 14:12
@AustinAbro321 AustinAbro321 requested review from a team as code owners August 12, 2025 14:12
brandtkeller
brandtkeller reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing thought before completing review.

@AustinAbro321
remove cargo from dependabot
fa05355 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
git merge main
3b8cd3d 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
hardcode the injector
0789792 
Signed-off-by: Austin Abro <austinabro321@gmail.com>
soltysh
soltysh approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

brandtkeller
brandtkeller approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brandtkeller brandtkeller added this pull request to the merge queue Aug 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2025
@brandtkeller brandtkeller added this pull request to the merge queue Aug 21, 2025
Merged via the queue into main with commit 552d1b4 Aug 21, 2025
39 checks passed
@brandtkeller brandtkeller deleted the use-injector-from-injector-repo branch August 21, 2025 18:18
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
@AustinAbro321 @Ansible-man
chore: remove injector from this repo, use injector from zarf-dev/zar…
883de05 
…f-injector (zarf-dev#4070)

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@brandtkeller brandtkeller brandtkeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform tag-driven zarf injector releases
3 participants
@AustinAbro321 @soltysh @brandtkeller