feat: allow interactive remove #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Austin Abro <austinabro321@gmail.com>
mkcp
previously approved these changes
Aug 13, 2025
Co-authored-by: Kit Patella <kit@defenseunicorns.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
mkcp
approved these changes
Aug 13, 2025
brandtkeller
approved these changes
Aug 13, 2025
Just chiming in here but we also experienced this issue as well using zarf v0.58.0 while trying to remove a component within a uds core package. We thought it was expected behavior so I never reported this but it did cause some issues and broke our core deployment putting it in a funky state... |
Ansible-man
pushed a commit
to Ansible-man/zarf
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com> Signed-off-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Co-authored-by: Kit Patella <kit@defenseunicorns.com> Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows users to preform an interactive remove when
--confirmis not set. I also added the package yaml print as I feel it could be a useful debugging tool if something went wrong during a confirmed remove. It's also consistent with our other interactive option, deploy. I don't feel super strongly either way here though.Related Issue
Fixes #3239
Checklist before merging