Skip to content

Conversation

AustinAbro321
Copy link
Contributor

Description

Allows users to use absolute paths again. Also eliminates some duplication between find-images / inspect and assemble

Related Issue

Fixes #3867

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link

netlify bot commented Aug 4, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 52e4af4
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/689258c476d917000804469c

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 46.42857% with 60 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/packager/layout/assemble.go 47.87% 30 Missing and 19 partials ⚠️
src/pkg/packager/inspect.go 38.88% 7 Missing and 4 partials ⚠️
Files with missing lines Coverage Δ
src/pkg/packager/inspect.go 13.13% <38.88%> (ø)
src/pkg/packager/layout/assemble.go 45.72% <47.87%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review August 5, 2025 14:19
@AustinAbro321 AustinAbro321 requested review from a team as code owners August 5, 2025 14:19
brandtkeller
brandtkeller previously approved these changes Aug 5, 2025
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified no change to package structure or templating compared to latest release. LGTM.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Aug 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321
Copy link
Contributor Author

AustinAbro321 commented Aug 5, 2025

@brandtkeller needs re-approval, had to fix a test flake. Was creating a file without closing it.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 7b3e8be Aug 5, 2025
27 checks passed
@AustinAbro321 AustinAbro321 deleted the fix-absolute-paths branch August 5, 2025 22:05
Ansible-man pushed a commit to Ansible-man/zarf that referenced this pull request Sep 6, 2025
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarf dev find-images errors on absolute path for valuesFiles
2 participants