feat(feature): Implement Feature API #4039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
src/internal/feature/feature.go
Outdated
|
|
||
| // Set takes a slice of one or many flags, inserting the features onto user-configured features. If a feature name is | ||
| // provided that is already a part of the set, then Set will return an error. | ||
| // TODO: Should we allow users to call this multiple times even if we don't allow them to overwrite features? |
There was a problem hiding this comment.
I think dis-allowing is fine. If there's a world where we need to allow multiple sets in the future then we could change it, but this is probably the most intuitive option since there's always an error on the second attempt
There was a problem hiding this comment.
Yeah i'm happy with the current behavior as well.
The main edge case I could see this creating is when a user is calling the SDK in one "context" with one set of feature flags, and then needs a different set of flags for a different context later but within the same running process. The workaround is just to enable everything up front, but issues could still arise. Simple enough to ease the restriction later though.
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Signed-off-by: Kit Patella <kit@defenseunicorns.com>
3912dce to
652e6cf
Compare
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
brandtkeller
reviewed
Aug 4, 2025
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Kit Patella <kit@defenseunicorns.com> Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Ansible-man
pushed a commit
to Ansible-man/zarf
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Kit Patella <kit@defenseunicorns.com> Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com> Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
internal/featureAPI as described in ZEP-0035 Feature Flags. It creates a new packagefeaturewhich allows maintainers to set defaultFeatures, and provides facilities for users to enable and disable features for use in the SDK. Before release we should ship at least one default feature flag, even a test/documentation noop feature struct, to enforce that setDefault can only be called once.In a follow-up PR we'll implement:
feature.SetUser) will be applied in the cmd layer to allow users to configure their own features via CLI flags, Env vars, and on-disk config.Related Issue
Implements part of ZEP-0035
Checklist before merging