fix(tools): update-creds handle registry subpaths #4026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Ansible-man
pushed a commit
to Ansible-man/zarf
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com> Signed-off-by: Cade Thomas <cadethomas23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix support for subpaths in the use of external registries during
zarf tools update-creds agent.Most managed external registries will not have the root registry available to push images. Rather a organization with nested projects may be defined - such as
registry.example.com/organization.Zarf init for the agent - which is pre-mutation - is set as
registry.example.com/organization/zarf-dev/zarf/agent:<tag>In this scenario - the current logic for updating the agent tls certificate was identifying:
registry =
registry.example.compath =
organization/zarf-dev/zarf/agentand assigning the full path -
organization/zarf-dev/zarf/agent- to the image - which when the registry is appended now equalsregistry.example.com/organization/organization/zarf-dev/zarf/agent:<tag>.This fixes the behavior by trimming subpaths when present - as the
registry-urlshould indeed declare subpaths if utilized.Related Issue
Fixes #4024
Checklist before merging