Reviewed 6 of 6 files at r1.
Reviewable status: 0 of 2 LGTMs obtained

Is JDT the odd one out or would there be any possible benefit to making this more general?

Reviewed 4 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)

ycmd/default_settings.json, line 36 at r2 (raw file):

  "clangd_args": [],
  "clangd_uses_ycmd_caching": 1,
  "java_jdtls_extension_path": []

Why is this a list?

ycmd/completers/java/java_completer.py, line 160 at r2 (raw file):

      manifest_json = utils.ReadFile( manifest_file )
      try:
        # TODO: use load and npt ReadFile

I have no idea what this TODO is trying to say.

ycmd/completers/java/java_completer.py, line 280 at r2 (raw file):

  def DefaultSettings( self, request_data ):
    return {
      'bundles': self._bundles

"Bundles" as in "extensions" as in "jdt plugins"?

ycmd/tests/java/subcommands_test.py, line 1858 at r2 (raw file):

  RunTest( app, {
    'description': 'Running a command does what it says it does',

Haha... "DoTheThing.cmd"

ycmd/tests/java/subcommands_test.py, line 1867 at r2 (raw file):

    },
    'expect': {
      # We dont specify the path for import organize, and jdt.ls returns shrug

But you did specify the path to Test.java. Why am I confused?

jdt.ls is unique in this regard. This "extensions" mechanism is implemented solely by jdt.ls, for jdt.ls. It's not part of the LSP; they are supplied in the initialisation settings.

Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)

ycmd/default_settings.json, line 36 at r2 (raw file):

So that you can have multiple entries, like the PATH variable. We actually append our default path to this list so that we can unilaterally install extensions as part of ycmd.

ycmd/completers/java/java_completer.py, line 160 at r2 (raw file):

oh yeah, it's saying to use json.load( manifest_file) rather than utils.ReadFile( manifest_file )\n json.loads( ... ).

It's not important (I don't remember writing it!)

ycmd/completers/java/java_completer.py, line 280 at r2 (raw file):

'bundles' is the name of the key in the settings object we pass to jdt.ls. They themselves call them extensions. But yeah, terminology. Strictly, I guess bundles is the correct term.

I use extension path, because it should actually essentially point at VScode extensions, not to the actual bundle jars. This is to make configuration easier.

For example if you use VScode to install some VSCode extensions such as the java debugger, PDT tools for jdt, etc. then you can just point at its extension directory, and we read the package.json.

ycmd/tests/java/subcommands_test.py, line 1867 at r2 (raw file):

there is an argument to the 'java.edit.organizeImports` command which is The URI of the file (or maybe files? to organise). In our actual organise imports implementation we pass the current file. IN this test, we pass nothing and the command does noting.

Reviewable status: 0 of 2 LGTMs obtained (waiting on @puremourning)

ycmd/completers/java/java_completer.py, line 160 at r2 (raw file):

Oh, so npt is a typo of not!

Please remove the comment, because it's super confusing.

Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)

ycmd/completers/java/java_completer.py, line 160 at r2 (raw file):

Done.

Reviewed 2 of 2 files at r2.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic and @puremourning)

Reviewed 1 of 1 files at r3.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)

Reviewed 1 of 6 files at r1, 1 of 1 files at r3.
Reviewable status: 1 of 2 LGTMs obtained

Reviewed 1 of 2 files at r4, 4 of 4 files at r5.
Reviewable status: 1 of 2 LGTMs obtained (and 1 stale)