Skip to content

fix: context should override parsed argv #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2017
Merged

fix: context should override parsed argv #786

merged 1 commit into from
Feb 25, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Feb 18, 2017

BREAKING CHANGE: context now takes precedence over argv

context object should take precedence over parsed values in argv.

fixes: #724

CC: @scriptdaemon I think this is better behavior for writing chat-bots using yargs.

@bcoe bcoe requested a review from maxrimue February 18, 2017 18:41
@stevezhu stevezhu merged commit fb9be80 into 7.x Feb 25, 2017
@stevezhu stevezhu deleted the context-application-order branch February 25, 2017 06:06
@bcoe
Copy link
Member Author

bcoe commented Feb 25, 2017

@stevezhu awesome 👍 thanks for landing this.

bcoe added a commit that referenced this pull request Feb 26, 2017
@bcoe
fix: context should override parsed argv (#786)
0997288 
BREAKING CHANGE: context now takes precedence over argv and defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrimue maxrimue maxrimue approved these changes

Assignees
No one assigned
Labels
hackillinois
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @maxrimue @stevezhu