Skip to content

introduce support for default commands #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2017
Merged

introduce support for default commands #785

merged 4 commits into from
Feb 26, 2017

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Feb 18, 2017 •
edited
Loading

@nexdrew's work on introducing default command support.

Why this is cool:

  1. it allows you to use the same flow control logic for top-level execution of yargs, as is applied to sub-commands.
  2. tons of people have asked for it.

todo:

  • add tests for simple behavior.
  • add tests for behavior in conjunction with strict mode.
  • add tests for behavior when loading commands from directories.
  • document functionality.

@bcoe bcoe force-pushed the default-command-7.x branch from e151f42 to 6294c1e Compare February 18, 2017 20:12
@bcoe bcoe requested a review from JaKXz February 18, 2017 20:52
@bcoe
Copy link
Member Author

bcoe commented Feb 18, 2017

@sondr3, @m-mujica, @ahmadnassri, @vjpr, would love feedback on this feature -- definitely the feature I'm most excited about for yargs@7.

@bcoe bcoe force-pushed the default-command-7.x branch from 217cefa to 586eaba Compare February 26, 2017 07:42
pahdo
pahdo approved these changes Feb 26, 2017
View reviewed changes
Copy link

@pahdo pahdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bcoe bcoe changed the title [WIP] introduce support for default commands introduce support for default commands Feb 26, 2017
@bcoe bcoe merged commit b4fb629 into 7.x Feb 26, 2017
@bcoe bcoe deleted the default-command-7.x branch February 26, 2017 08:34
bcoe added a commit that referenced this pull request Feb 26, 2017
@bcoe
feat: introduces support for default commands, using the '*' identifi…
d78a0f5 
…er (#785)
@ahmadnassri
Copy link

this is great!! thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz Awaiting requested review from JaKXz

1 more reviewer

@pahdo pahdo pahdo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nexdrew nexdrew

@maxrimue maxrimue

Labels
hackillinois
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcoe @ahmadnassri @pahdo @nexdrew @maxrimue