Skip to content

Conversation

Mirwaisse
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • [] I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Typos in the README file.

@bot-boi
Copy link

bot-boi commented Oct 24, 2021

changes are: capitalize proper nouns, add missing punctuation, add missing hyphens (ie platform-specific, 32-bit), fix some spelling errors, don't capitalize after an ellipse

Copy link

@mechanical-snail mechanical-snail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up.

Mirwaisse and others added 3 commits October 25, 2021 01:33
@pukkandan
Copy link
Member

I can tell care and thought has been put into this PR. So I will merge it.

But in general, I do not want to encourage PRs like these. As long as the text remains readable and clear, I am not interested in fixing all grammatical mistakes that have been and will be made in the documentation. I will not be spending my time reviewing/fixing these types of changes in the future

@pukkandan pukkandan added the docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc label Oct 25, 2021
pukkandan added a commit that referenced this pull request Oct 31, 2021
@pukkandan pukkandan closed this Oct 31, 2021
@pukkandan pukkandan mentioned this pull request Oct 31, 2021
9 tasks
gaming-hacker added a commit to gaming-hacker/yt-dlp that referenced this pull request Nov 3, 2021
* master: (28 commits)
  [ffmpeg] Detect libavformat version for `aac_adtstoasc` and print available features in verbose head Based on ytdl-org/youtube-dl#29581
  [ffmpeg] Accurately detect presence of setts
  [ExtractAudio] Use `libfdk_aac` if available Closes yt-dlp#1502 Authored by: CrypticSignal
  [ffmpeg] Framework for feature detection Related: yt-dlp#1502, yt-dlp#1237, ytdl-org/youtube-dl#29581
  [ExtractAudio] Rescale --audio-quality correctly Authored by: CrypticSignal, pukkandan
  [fragment] Fix progress display in fragmented downloads Closes yt-dlp#1517
  [youtube] Remove unnecessary no-playlist warning
  [utils] Parse `vp09` as vp9
  [jsinterp] Handle default in switch better
  [Instagram] Fix incorrect resolution (yt-dlp#1494)
  [vk] Fix login (yt-dlp#1495)
  [docs,cleanup] Improve docs and minor cleanup Closes yt-dlp#1387, yt-dlp#1404, yt-dlp#1408, yt-dlp#1485, yt-dlp#1415, yt-dlp#1450, yt-dlp#1492
  [youtube] refactor itag processing
  [linkedin] Don't login multiple times
  [vk] Add subtitles (yt-dlp#1480)
  [Olympics] Fix extractor (yt-dlp#1483)
  [PlanetMarathi] Add extractor (yt-dlp#1484)
  [Instagram] Add login to playlist (yt-dlp#1488)
  [ceskatelevize] Fix extractor (yt-dlp#1489)
  [youtube] Fix throttling by decrypting n-sig (yt-dlp#1437)
  ...
@pukkandan pukkandan mentioned this pull request Dec 20, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs/meta/cleanup related to docs, code cleanup, templates, devscripts etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants