fix psql comments #404
Merged
fix psql comments #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@n-r-w This is fine, could you rebase this as a single commit though? Also, if you wanted to add comments for the PostgreSQL schemas in the |
90d36f1 to
c001e59
Compare
Rebase is completed. |
|
@n-r-w thanks for the rebase. Will merge this. Just was hoping you'd save me a bit of work on the comments/schema example ;) |
kenshaw
added a commit
to xo/homebrew-xo
that referenced
this pull request
May 24, 2024
## What's Changed * fix psql comments by @n-r-w in xo/dbtpl#404 * Fix postresql multiline comments by @n-r-w in xo/dbtpl#406 ## New Contributors * @n-r-w made their first contribution in xo/dbtpl#404 **Full Changelog**: xo/dbtpl@v1.0.1...v1.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For postgresql, comments for tables are not extracted from the database. In addition, the default template does not use information about comments.