Address warnings with filenames ending in fullstop on Windows #5951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the failing unit tests are addressed by #5950 |
swissspidy
reviewed
May 23, 2024
swissspidy
reviewed
May 23, 2024
swissspidy
reviewed
May 23, 2024
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
…wp-cli into add/filecache-import-tests
|
Hmm... the PHPUnit methods are static methods but the documentation's examples do use the instance
|
swissspidy
approved these changes
May 23, 2024
.
lipemat
added a commit
to lipemat/wp-cli-bundle
that referenced
this pull request
Jun 6, 2024
The sister pull request was merged which resolved the issue. wp-cli/wp-cli#5951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lipemat opened PR #5947 to address an issue with filenames of premium plugins.
The failure was occurring with:
Tests with those values passed on MacOS, but Microsoft's documentation says:
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions
The primary fix for this is to
rtrim()the.duringFileCache::validate_key(): c38a371, confirmed working: #5947 (comment)Before realising the root issue, I had added a fix for the error message, 32ba58d, to begin, I needed to add a test for the happy path: 6f0b0e9, and I also added some comments and typehints I needed to debug.