Use proper WP_User_Query
for fetching users
#5600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a fundamental difference between
get_user_by()
andget_users()
. Where the former creates a newWP_User
object and initiates it via an array of data, the latter puts the actual database result into theWP_User
's$data
property via its constructor.The end result is that the set of available properties is different. As an example, when a user is fetched via
get_users()
, it knows about itsnickname
. If it is fetched byget_user_by()
, thenickname
property does not exist.This PR changes the
UserFetcher
to rely onget_users()
(instead ofget_user_by()
), to make all properties available.