Re-add subcommands on all composite commands that are overwritten #5584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3948175 to
582869f
Compare
wojsmol
reviewed
Dec 3, 2021
50d2080 to
316311b
Compare
316311b to
fb15fd3
Compare
3559a7e to
a359a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #5563 .
Instead of only porting over subcommand on command namespace, we're doing so on all composite commands. This way, if a command is registered multiple times, it will still work as expected, while still allowing overrides.
The override needs to be registered as a subcommand in the new composite command, so it will take precedence over the subcommand that were previously registered.
Also, this adapts PHPUnit tests to make them work on PHP 8.1.