Skip to content

Fix regression that broke extending existing commands #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix regression that broke extending existing commands #5563

merged 2 commits into from
Nov 11, 2021

Conversation

schlessera
Copy link
Member

There was a regression in the code that handles command namespaces that made it impossible to extend an existing command class.

This PR reverts the regression and adds a test scenario to ensure this type of extension will not be regressing again.

Fixes #5274

@schlessera schlessera requested a review from a team as a code owner September 16, 2021 15:49
@schlessera schlessera added this to the 2.5.1 milestone Sep 16, 2021
sun
sun approved these changes Sep 30, 2021
View reviewed changes
Copy link

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple fix accompanied with tests, which are passing. 👍

Wondering whether we should restore the final condition testing for other possible values of existing commands that were removed in the previous commit that introduced the test for false in #5203?

wp-cli/php/class-wp-cli.php

Lines 536 to 539 in 7e12cae

} elseif ( false !== $existing_command ) {
// Command already registered, so abort to avoid double registration.
return false;
}

@schlessera
Copy link
Member Author

Wondering whether we should restore the final condition testing for other possible values of existing commands that were removed in the previous commit that introduced the test for false in #5203?

I think that would make it impossible again to override bundled commands, as the new command would just be skipped.

@schlessera schlessera merged commit 75bb33e into master Nov 11, 2021
@schlessera schlessera deleted the fix/5274-allow-extending-bundled-commands branch November 11, 2021 15:25
@schlessera schlessera mentioned this pull request Dec 3, 2021
Merged
This was referenced Jan 6, 2022
Closed
Closed
@Dan-Q Dan-Q mentioned this pull request Jun 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sun sun sun approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
scope:framework
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Extending an existing command stopped working in 2.2.0
2 participants
@schlessera @sun