Skip to content

Fix stdout/stderr redirection when log disabled #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix stdout/stderr redirection when log disabled #391

merged 1 commit into from
Feb 12, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 30, 2020 •
edited
Loading

Hold for #390

stdout/stderr must be read or closed to unblock the child process' write operations.

@nxtn nxtn marked this pull request as ready for review February 2, 2020 03:20
@nxtn nxtn requested a review from oleg-nenashev as a code owner February 2, 2020 03:20
@oleg-nenashev oleg-nenashev changed the base branch from master to test-4.x February 5, 2020 17:52
@oleg-nenashev oleg-nenashev changed the base branch from test-4.x to master February 5, 2020 17:52
oleg-nenashev
oleg-nenashev approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@oleg-nenashev oleg-nenashev merged commit 9a7e0b1 into winsw:master Feb 12, 2020
@nxtn nxtn deleted the redirect branch February 13, 2020 02:11
@nxtn nxtn modified the milestone: 2.6.0 Mar 25, 2020
@Legiew Legiew mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nxtn @oleg-nenashev