Skip to content

Stop buffering stdout/stderr #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Stop buffering stdout/stderr #390

merged 1 commit into from
Jan 31, 2020

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Jan 30, 2020

Fixes #266

@nxtn nxtn requested a review from oleg-nenashev as a code owner January 30, 2020 09:02
@nxtn nxtn mentioned this pull request Jan 30, 2020
Merged
oleg-nenashev
oleg-nenashev approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 for that. With virtual machines and infrastructure-as-cattle approaches log buffering becomes a nightmare. Not to speak about crashes

@oleg-nenashev oleg-nenashev merged commit a1df447 into winsw:master Jan 31, 2020
@nxtn nxtn deleted the line branch February 1, 2020 01:50
This was referenced Feb 26, 2020
Closed
Merged
@nxtn nxtn modified the milestone: 2.5.0 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

Log buffering way too long
2 participants
@nxtn @oleg-nenashev