Skip to content

Conversation

adidenko
Copy link
Collaborator

@adidenko adidenko commented Nov 6, 2023

Description

We need to initialize success and error counters properly in order to avoid having undefined metrics.

Closes: #59

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

We need to initialize success and error counters properly in order
to avoid having undefined metrics.

Closes: #59
@adidenko adidenko merged commit 21b0d68 into main Nov 6, 2023
@adidenko adidenko deleted the fix_metrics_bug branch November 6, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Success and error counters are not initialised properly and could be undefined
2 participants