Skip to content

Success and error counters are not initialised properly and could be undefined #59

@adidenko

Description

@adidenko

Description

  1. minigun_requests_success_total metric is undefined when not a single request succeeded
  2. minigun_requests_errors_total metric is undefined when not a single request failed

Which breaks success/error ratio queries and dashboards

Expected Behaviour

Both metrics should be initialised with zero value

Actual Behaviour

Metrics are undefined

Affected Version

0.5.0

Steps to Reproduce

  1. Run minigun -fire-target http://dont-exist.cluster.local.svc/ -fire-rate 1 -fire-duration 1m
  2. Check minigun_requests_success_total
  3. It does not exist

Checklist

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions