-
Notifications
You must be signed in to change notification settings - Fork 9
ENH: Add segment module with ava algorithm, fixes #40 #46 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it and rename that audio_amplitude.py
…gment/test_audio_amplitude.py
…plitude.py to indicate correct return values, revise docstring to better explain segmenting algorithm
…nal function from ava; remove changes I made
…docstrings, add defaults to spectrogram function
…finet et al., 2021
…s with segmentation from ava (Goffinett al., 2021)
…s/fixtures/audio.py
…s/fixtures/segment.py
…l.segment.audio_amplitude -> vocalpy.segment.audio_amplitude
…litude -> vocalpy.segment.audio_amplitude
…ngs, will fix this in another branch
For some reason the Ci runs on Ubuntu are failing. I'm going to go ahead and merge, it passes on other platforms |
14 tasks
NickleDave
added a commit
that referenced
this pull request
Sep 19, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to address #40 by creating a
vocalpy.segment
module, and adding one more algorithm for segmenting, from theava
package, as in #46