-
Notifications
You must be signed in to change notification settings - Fork 787
Support for mapping between tunnel id and vlan #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This project follows a one feature/fix/change per PR and one commit per PR approaches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks legit. left one small comment.
also please rebase and squash to a single commit
return nil, fmt.Errorf("failed to parse nested attr %v", err) | ||
} | ||
for _, nestAttr := range nestedAttrs { | ||
switch nestAttr.Attr.Type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this to separate func (e.g parseTunnelInfo(attrs)
or maybe a method of TunnelInfo )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, im gonna do it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will create 2 PRs as it was asked above.
remove comments about broadcast when deleting address remove another comment about broadcast auto calculation
Update the Go version we test against to Go v1.22 which is currently the oldest version still receiving security updates. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
2. filter action support vlan pop/push.
Add deserialization of the `IFF_RUNNING` link flag which translates to `net.FlagRunning`. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Similar to #1018, but for ConntrackDeleteFilters() Relates to kubernetes/kubernetes#129562
These attributes are supported since kernel v5.14 (see [1]). Here's what iproute2 shows: ``` $ ip -d link show eth0 4: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65535 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000 ... parentbus virtio parentdev virtio0 ``` [1]: torvalds/linux@00e77ed Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Currently, the ConntrackDeleteFilters captures all flow entries it fails to delete and reports them as errors. This behavior can potentially lead to memory leaks in high-traffic systems, where thousands of conntrack flow entries are cleared in a single batch. With this commit, instead of returning all the un-deleted flow entries, we now return a single error message for all of them. Signed-off-by: Daman Arora <aroradaman@gmail.com>
What if the data length of attribute is 4? The attribute will be ignored, because `i+4 < len(data)`. Signed-off-by: Leon Hwang <hffilwlqm@gmail.com>
Signed-off-by: Sven Rebhan <srebhan@influxdata.com>
binary.Read() != nil check means error case, so the vxlan.Port{Low,High} are never populated. Fix the check. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Jordan Rife <jrife@google.com>
When adding a route with "mtu lock <mtu>" path MTU discovery (PMTUD) will not be tried and packets will be sent without DF bit set. Upon receiving an ICMP needs frag due to PMTUD, the kernel will not install a cached route and lower the MTU. Signed-off-by: Tim Rozet <trozet@redhat.com>
TcGen was missing in pedit action and the kernel cannont correctly process pedit action. Signed-off-by: Chen Tang <tangchen.1@bytedance.com>
- Adding file path for nerdctl and finch full diff: vishvananda/netns@v0.0.4...v0.0.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The `RouteGetWithOptions` function currently has a `Oif` option which gets translated from link name to link index via a `LinkByName` call. This adds unnecessary overhead when the link index is already known. This commit adds a new `OifIndex` option to `RouteGetWithOptions` which can be specified instead of `Oif` to skip the internal link index translation. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This change adds support for packet sampling using "psample" kernel module.
On Linux, Netlink provides NDA_CACHEINFO which carries timestamps about when ARP/ND was updated, used, and confirmed. Expose these fields in the Neigh type
Signed-off-by: Ivan Tsvetkov <ivanfromearth@gmail.com>
Introduce AddQueues and RemoveQueues methods for attaching and detaching queue file descriptors to an existing TUN/TAP interface in multi-queue mode. This enables controlled testing of disabled queues and fine-grained queue management without relying on interface recreation. Signed-off-by: Ivan Tsvetkov <ivanfromearth@gmail.com>
Some calls were already using it, some were not, but fix the remaining ones. Without this flag, the file descriptor would to the child process after fork/exec. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Signed-off-by: kayos@tcp.direct <kayos@tcp.direct>
This requirement limits the usefulness of labels (given the total label length can only be 15 characters). Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Vlan tunnel info feature #907
The feature was requested in this issue.
The PR makes possible to bind the vlan id with tunnel id (vxlan vni).