Skip to content

vishvananda Netlink breaking changes in 1.2.1 #129562

@aojea

Description

@aojea

The vishvananda netlink library had a behavior change in 1.2.1 , see vishvananda/netlink#1018 for more details

Before vishvananda/netlink#925 (in v1.2.1), the flag was ignored and results were returned without an error. With that change, response handling is aborted, results are discarded, and unix.EINTR is returned.

We are impacted by that change

github.com/vishvananda/netlink v1.3.1-0.20240905180732-b1ce50cfa9be

In order to recover the previous behavior and being more resilient to partial results we should adopt a similar solution to the one adopted by moby developers, wrapping the library to retry a few times

We need to implement something like moby/moby@00bf437#diff-28da2a9c14d97c7755152d3ad995389ceda8cc7655c8e03e2874b6d44f977ec1

We also should have some way of linting to avoid adding new netlink calls that are susceptible to get interrupted without the wrapper

/sig network
/priority important-soon

Metadata

Metadata

Labels

priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.sig/networkCategorizes an issue or PR as relevant to SIG Network.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions