resolve() was not tested with a symlink cycle #3513
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3513 +/- ##
=========================================
+ Coverage 76.87% 77.18% +0.3%
=========================================
Files 99 99
Lines 136451 139012 +2561
=========================================
+ Hits 104896 107291 +2395
- Misses 31555 31721 +166
Continue to review full report at Codecov.
|
|
A few lines in resolve() are still not covered. |
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Oct 6, 2018
Problem: resolve() was not tested with a symlink cycle. Solution: Add a test. (Dominique Pelle, closes vim/vim#3513) vim/vim@2610990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the resolve() function.
In particular, testing with symlink cycle was not covered
with tests according to codcov:
https://codecov.io/gh/vim/vim/src/2bc152ab53c4b01072edf6ec2ff61e504cb03cbe/src/evalfunc.c#L9657
I put some FIXME comments in the test where resolve() does not behave
as I expected.
I'll remove WIP in the title when CI shows enough code coverage.