Fix executable() on windows #3512
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work as: * SearchPath return TRUE with direct name * File exists with appending extensions contains PATHEXT
Codecov Report
@@ Coverage Diff @@
## master #3512 +/- ##
==========================================
+ Coverage 76.87% 77.16% +0.29%
==========================================
Files 99 99
Lines 136451 139012 +2561
==========================================
+ Hits 104896 107271 +2375
- Misses 31555 31741 +186
Continue to review full report at Codecov.
|
|
Yasuhiro Matsomoto wrote:
Current implementation of executable() return 1 even though it is not
an executable. On Windows, executable command must have suffix that
contains in PATHEXT. But current implementation check...
Is this really always true? Perhaps it depends on $SHELL?
… * If it have file extension and the name exists in curdir or PATH.
* If the filename with appending suffixes exists in curdir or PATH.
So `executable('shell32.dll')` or `executable('win.ini')` return 1.
--
hundred-and-one symptoms of being an internet addict:
155. You forget to eat because you're too busy surfing the net.
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
If $SHELL is used, the name is used directly. Line 3541 in 2bc152a |
|
Fixed by 8.1.0453. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of executable() return 1 even though it is not an executable. On Windows, executable command must have suffix that contains in PATHEXT. But current implementation check...
So
executable('shell32.dll')orexecutable('win.ini')return 1.