[RFC] f_executable: do not return TRUE if -1 mch_can_exe returns -1 #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure about this, since e.g. for amiga it will then never be true.
blueyed
added a commit
to blueyed/vim
that referenced
this pull request
Aug 5, 2018
Without this `executable("foobar")` is 1 after `let $PATH=""`.
vim#3282 would change/fix this already, but
I think an empty $PATH should not be considered to be "not implemented".
This is not a real use case, but I am using this in tests.
Codecov Report
@@ Coverage Diff @@
## master #3282 +/- ##
==========================================
- Coverage 76.57% 76.54% -0.04%
==========================================
Files 93 93
Lines 136871 136871
==========================================
- Hits 104815 104767 -48
- Misses 32056 32104 +48
Continue to review full report at Codecov.
|
|
Daniel Hahler wrote:
Not sure about this, since e.g. for amiga it will then never be true.
mch_can_exe() is used in this way in several other places. It's better
if we don't let it return -1, since that is never checked for. Better
return FALSE then.
…--
Two cows are standing together in a field. One asks the other:
"So what do you think about this Mad Cow Disease?"
The other replies: "That doesn't concern me. I'm a helicopter."
/// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about this, since e.g. for amiga it will then never be true.