options: improve copying of buffer-local value of window option #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
==========================================
- Coverage 74.43% 74.42% -0.02%
==========================================
Files 90 90
Lines 132185 132176 -9
Branches 30904 30742 -162
==========================================
- Hits 98394 98371 -23
- Misses 33766 33776 +10
- Partials 25 29 +4
Continue to review full report at Codecov.
|
previously, only a value is copied from another window if the buffer is not current in that window. With this change, it is also copied from a window, in which the buffer is currently displayed.
|
Tests are passing now after adding missing NULL check. |
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: Buffer-local window options may not be recent if the buffer is
still open in another window.
Solution: Copy the options from the window instead of the outdated window
options. (Bjorn Linse, closes vim#2336)
bfredl
added a commit
to bfredl/neovim
that referenced
this pull request
Jun 21, 2018
…other window
patch 8.0.1836: buffer-local window options may not be recent
Problem: Buffer-local window options may not be recent if the buffer is
still open in another window.
Solution: Copy the options from the window instead of the outdated window
options. (Bjorn Linse, closes vim/vim#2336)
bfredl
added a commit
to bfredl/neovim
that referenced
this pull request
Jun 21, 2018
…other window
vim-patch:8.0.1836: buffer-local window options may not be recent
Problem: Buffer-local window options may not be recent if the buffer is
still open in another window.
Solution: Copy the options from the window instead of the outdated window
options. (Bjorn Linse, closes vim/vim#2336)
vim/vim@25782a7
bfredl
added a commit
to bfredl/neovim
that referenced
this pull request
Jun 21, 2018
…other window
vim-patch:8.0.1836: buffer-local window options may not be recent
Problem: Buffer-local window options may not be recent if the buffer is
still open in another window.
Solution: Copy the options from the window instead of the outdated window
options. (Bjorn Linse, closes vim/vim#2336)
vim/vim@25782a7
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 22, 2018
Problem: Buffer-local window options may not be recent if the buffer is
still open in another window.
Solution: Copy the options from the window instead of the outdated window
options. (Bjorn Linse, closes vim/vim#2336)
vim/vim@25782a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, only a value is copied from another window if the buffer
is not current in that window. With this change, it is also copied
from a window, in which the buffer is currently displayed.
Previous discussion: neovim/neovim#7551