Fix E315 when writing to hidden buffer using python buffer object #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP because tests failing on py2. Working on it. |
e9188db to
a24e696
Compare
|
Fixed the tests (hopefully) |
Codecov Report
@@ Coverage Diff @@
## master #4154 +/- ##
==========================================
+ Coverage 79.23% 79.25% +0.02%
==========================================
Files 105 105
Lines 141092 141094 +2
==========================================
+ Hits 111792 111826 +34
+ Misses 29300 29268 -32
Continue to review full report at Codecov.
|
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Mar 23, 2019
…ffer
Problem: E315 ml_get error when using Python and hidden buffer.
Solution: Make sure the cursor position is valid. (Ben Jackson,
closes vim/vim#4153, closes vim/vim#4154)
vim/vim@63dbfd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4153
Tests fail prior to change and pass afterwards.
I found that the check before calling
py_fix_cursoris not consistently applied, so this patch applies it more consistently.