Fix QuotaExceededError regression caused by change in Chrome 138 #7368
+24
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
commented
Jul 2, 2025
…thout interfering with append retries when there is no alternate
5 tasks
luwes
added a commit
to muxinc/elements
that referenced
this pull request
Jul 3, 2025
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This change ensures that QuotaExceededError is handled properly even after changes proposed in whatwg/webidl#1465 or any other change that would prevent identification of an append error as a "buffer full" (QuotaExceededError) error.
Why is this Pull Request needed?
Handles error object with incorrect
code(!= 22), and always reduces max buffer length on append error.Prevents first append error that is not a buffer full from being escalated to fatal when there are no other levels (allowing for retries up to
appendErrorMaxRetry).Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #7367
Checklist